[SPARK-14204] [SQL] register driverClass rather than user-specified class#14420
Closed
mchalek wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-14204] [SQL] register driverClass rather than user-specified class#14420mchalek wants to merge 1 commit intoapache:masterfrom
mchalek wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Jenkins test this please |
|
Test build #63043 has finished for PR 14420 at commit
|
Contributor
|
@srowen will this pr be meged into branch-2.0? |
Member
|
I'll wait a moment to see if @JoshRosen has concerns about it. The original change was approved, for branch 1.6, but in re-reading, I wonder if it was only accidentally discussed as 1.6-only. |
Contributor
|
@JoshRosen can you have a look at this pr? |
Member
|
Going once going twice; I don't see a reason to not merge to |
asfgit
pushed a commit
that referenced
this pull request
Aug 3, 2016
This is a pull request that was originally merged against branch-1.6 as #12000, now being merged into master as well. srowen zzcclp JoshRosen This pull request fixes an issue in which cluster-mode executors fail to properly register a JDBC driver when the driver is provided in a jar by the user, but the driver class name is derived from a JDBC URL (rather than specified by the user). The consequence of this is that all JDBC accesses under the described circumstances fail with an IllegalStateException. I reported the issue here: https://issues.apache.org/jira/browse/SPARK-14204 My proposed solution is to have the executors register the JDBC driver class under all circumstances, not only when the driver is specified by the user. This patch was tested manually. I built an assembly jar, deployed it to a cluster, and confirmed that the problem was fixed. Author: Kevin McHale <kevin@premise.com> Closes #14420 from mchalek/mchalek-jdbc_driver_registration. (cherry picked from commit 685b08e) Signed-off-by: Sean Owen <sowen@cloudera.com>
Member
|
Merged to master/2.0 (previously merged to 1.6) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request that was originally merged against branch-1.6 as #12000, now being merged into master as well. @srowen @zzcclp @JoshRosen
This pull request fixes an issue in which cluster-mode executors fail to properly register a JDBC driver when the driver is provided in a jar by the user, but the driver class name is derived from a JDBC URL (rather than specified by the user). The consequence of this is that all JDBC accesses under the described circumstances fail with an IllegalStateException. I reported the issue here: https://issues.apache.org/jira/browse/SPARK-14204
My proposed solution is to have the executors register the JDBC driver class under all circumstances, not only when the driver is specified by the user.
This patch was tested manually. I built an assembly jar, deployed it to a cluster, and confirmed that the problem was fixed.